Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

messenger callbacks having return values ignored in validation layer #103

Open
rpavlik opened this issue Aug 2, 2019 · 0 comments

Comments

@rpavlik
Copy link
Contributor

commented Aug 2, 2019

Found with clang-tidy:

OpenXR-SDK-Source/src/api_layers/core_validation.cpp:270:34: warning: Value stored to 'ret_val' during its initialization is never read [clang-analyzer-deadcode.DeadStores]
                        XrBool32 ret_val = messenger_create_info->userCallback(debug_utils_severity,

It's not being used because this call (and many including it) are void return. I think it should at least abort the loop, though.

Fairly low priority.

cc @daveh-lunarg

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.