Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export All API symbols #100

Open
wants to merge 3 commits into
base: master
from

Conversation

@rpavlik
Copy link
Contributor

commented Aug 2, 2019

Alternate to #98 suggested by @brycehutchings - this just treats "only export core" as a documentation bug. Keeps essentially the same behavior as right now, just fixes some bugs related to exporting. (and cuts the exports of internal symbols)

Fixes #45

@rpavlik rpavlik requested a review from daveh-lunarg Aug 2, 2019

@rpavlik rpavlik added the in loader label Aug 2, 2019

@brycehutchings brycehutchings self-requested a review Aug 2, 2019

@rpavlik

This comment has been minimized.

Copy link
Contributor Author

commented Aug 2, 2019

We probably need to bring this to the WG.

@rpavlik rpavlik force-pushed the rpavlik:rp-export-all branch from b8f2f37 to 9c7e9bb Aug 5, 2019

@daveh-lunarg

This comment has been minimized.

Copy link
Contributor

commented Aug 6, 2019

Without building and dumpbinning each, what's the net effect of this vs #98?

@rpavlik

This comment has been minimized.

Copy link
Contributor Author

commented Aug 13, 2019

This one treats "only core is exported" as a documentation error, since we had been exporting everything (at least in shared-library/dll builds). It just makes the private, internal functions not-exported.

#98 treats the documentation as correct and the loader as very broken, and thus goes from exporting everything, including internal functions, to only exporting core functions. It therefore requires changes to the sample code in the spec, as well as hello_xr, etc.

@rpavlik rpavlik referenced this pull request Aug 13, 2019
@rpavlik

This comment has been minimized.

Copy link
Contributor Author

commented Aug 13, 2019

This change won't cause linker errors with code that built before. #98 will break linking potentially, because there won't be a xrGetOpenGLGraphicsRequirementsKHR() (etc) function exported from the loader.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.