Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate validation debug utils #104

Closed

Conversation

@rpavlik
Copy link
Contributor

commented Aug 2, 2019

Replaces #85 and #86 (contains both of them).

Factors out some code about debug messenger data, cleaning it up in the process.

Then, re-uses it in the validation layer too.

@rpavlik rpavlik requested a review from daveh-lunarg Aug 2, 2019

@daveh-lunarg
Copy link
Contributor

left a comment

Sure, LGTM

@daveh-lunarg

This comment has been minimized.

Copy link
Contributor

commented Aug 6, 2019

Replaced by PR #109.

@rpavlik rpavlik referenced this pull request Aug 13, 2019

rpavlik referenced this pull request Aug 13, 2019

CoreValidation: remove unlinked session label cleanup
Remove the call to *DeleteSessionLabels() within *DestroySession().
Can see no instance of a DebugUtilsData object and no InsertLabel()
or BeginLabelRegion() calls, so I believe the previous
CoreValidationDeleteSessionLabels() call was essentially a no-op.

@rpavlik rpavlik deleted the rpavlik:migrate-validation-debug-utils branch Aug 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.