Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

- Update json_stream initialization to improve compatibility #108

Merged
merged 1 commit into from Aug 13, 2019

Conversation

@theblindprogramm3r
Copy link

commented Aug 5, 2019

No description provided.

@CLAassistant

This comment has been minimized.

Copy link

commented Aug 5, 2019

CLA assistant check
All committers have signed the CLA.

@rpavlik
Copy link
Contributor

left a comment

One minor question, plus we need the CLA

src/loader/manifest_file.cpp Show resolved Hide resolved

@rpavlik rpavlik self-requested a review Aug 5, 2019

@rpavlik

rpavlik approved these changes Aug 5, 2019

@rpavlik

This comment has been minimized.

Copy link
Contributor

commented Aug 5, 2019

Hmm, I clicked the recheck but it still says pending . Can you click the cla recheck link?

@theblindprogramm3r

This comment has been minimized.

Copy link
Author

commented Aug 5, 2019

Hmm, I clicked the recheck but it still says pending . Can you click the cla recheck link?

I've gone back and done it, when I click on the link the top of the page says "You have signed the ...." and no longer offers a button to sign.

@rpavlik rpavlik merged commit 83ce430 into KhronosGroup:master Aug 13, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
license/cla Contributor License Agreement is signed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.