Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loader test changes #147

Merged
merged 2 commits into from Dec 3, 2019

Conversation

@rpavlik
Copy link
Contributor

rpavlik commented Nov 27, 2019

The first commit is a fix. The second one is extra output to figure out why I was getting a (presumably spurious?) failure when testing on Linux with no runtime installed:

~/src/OpenXR-SDK-Source(git✱≠master)❱✔≻ pushd build/src/tests/loader_test; ./loader_test; popd
Starting loader_test
--------------------
    Starting TestEnumLayers
        No explicit layers layer count check: Passed: 2 layers available.
        No explicit layers layer props query: Passed
           - XR_APILAYER_LUNARG_core_validation
           - XR_APILAYER_LUNARG_api_dump
        Simple explicit layers layer count check: Failed, expected count 8 (2 seen earlier plus 6 we added), got 6
        Simple explicit layers layer props query: Passed
           - XR_APILAYER_LUNARG_test_badnegotiate_invalid_api
           - XR_APILAYER_test
           - XR_APILAYER_LUNARG_test_badnegotiate_invalid_gipa
           - XR_APILAYER_LUNARG_test_badnegotiate_invalid_interface
           - XR_APILAYER_LUNARG_test_badnegotiate_always
           - XR_APILAYER_LUNARG_test_good_relative_path
    Finished TestEnumLayers : Failed (Local - Passed: 3, Failed: 1, Skipped: 0)

    Starting TestEnumInstanceExtensions
        JSON test_runtime_badjson_runtime_empty.json extension enum count query (with no explicit API layers): Passed
        JSON test_runtime_badnegotiate_invalid_gipa.json extension enum count query (with no explicit API layers): Passed
        JSON test_runtime_badjson_file_ver_minor_high.json extension enum count query (with no explicit API layers): Passed
        JSON test_runtime_badjson_file_ver_int.json extension enum count query (with no explicit API layers): Passed
        JSON test_runtime_badnegotiate_invalid_interface.json extension enum count query (with no explicit API layers): Passed
        JSON test_runtime_badnegotiate_invalid_api.json extension enum count query (with no explicit API layers): Passed
        JSON test_runtime_badjson_path_no_file.json extension enum count query (with no explicit API layers): Passed
        JSON test_runtime_badjson_path_int.json extension enum count query (with no explicit API layers): Passed
        JSON test_runtime_badjson_runtime_missing.json extension enum count query (with no explicit API layers): Passed
        JSON test_runtime_badjson_file_ver_missing.json extension enum count query (with no explicit API layers): Passed
        JSON test_runtime_badnegotiate_always.json extension enum count query (with no explicit API layers): Passed
        JSON test_runtime_badjson_path_missing.json extension enum count query (with no explicit API layers): Passed
        JSON test_runtime_badjson_file_ver_major_high.json extension enum count query (with no explicit API layers): Passed
        JSON test_runtime_badjson_file_ver_all_low.json extension enum count query (with no explicit API layers): Passed
        JSON test_runtime_badjson_file_ver_string.json extension enum count query (with no explicit API layers): Passed
        JSON test_runtime_badjson_runtime_empty.json extension enum count query (with explicit API layers): Passed
        JSON test_runtime_badnegotiate_invalid_gipa.json extension enum count query (with explicit API layers): Passed
        JSON test_runtime_badjson_file_ver_minor_high.json extension enum count query (with explicit API layers): Passed
        JSON test_runtime_badjson_file_ver_int.json extension enum count query (with explicit API layers): Passed
        JSON test_runtime_badnegotiate_invalid_interface.json extension enum count query (with explicit API layers): Passed
        JSON test_runtime_badnegotiate_invalid_api.json extension enum count query (with explicit API layers): Passed
        JSON test_runtime_badjson_path_no_file.json extension enum count query (with explicit API layers): Passed
        JSON test_runtime_badjson_path_int.json extension enum count query (with explicit API layers): Passed
        JSON test_runtime_badjson_runtime_missing.json extension enum count query (with explicit API layers): Passed
        JSON test_runtime_badjson_file_ver_missing.json extension enum count query (with explicit API layers): Passed
        JSON test_runtime_badnegotiate_always.json extension enum count query (with explicit API layers): Passed
        JSON test_runtime_badjson_path_missing.json extension enum count query (with explicit API layers): Passed
        JSON test_runtime_badjson_file_ver_major_high.json extension enum count query (with explicit API layers): Passed
        JSON test_runtime_badjson_file_ver_all_low.json extension enum count query (with explicit API layers): Passed
        JSON test_runtime_badjson_file_ver_string.json extension enum count query (with explicit API layers): Passed
    Finished TestEnumInstanceExtensions : Passed (Local - Passed: 30, Failed: 0, Skipped: 0)

No installed XR runtime detected - active runtime tests skipped(!)
    Results:
    ------------------------------
        Total Tests:    34
        Tests Passed:   33
        Tests Skipped:  0
        Tests Failed:   1
        Overall Result: Failed

Looks like it's losing the somehow-automatically-found layers.

@rpavlik rpavlik requested a review from bradgrantham-lunarg Nov 27, 2019
Copy link

bradgrantham-lunarg left a comment

LGTM

@rpavlik rpavlik merged commit 1cbb91b into KhronosGroup:master Dec 3, 2019
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
license/cla Contributor License Agreement is signed.
Details
rpavlik added a commit that referenced this pull request Dec 7, 2019
Patch release for the 1.0 series.

This release primarily contains extension reservations and small specification
clarifications/fixes.

### GitHub Pull Requests

These had been integrated into the public repo incrementally.

- Loader tests
  - #147 - Small bugfix and output extension

### Internal issues

- Registry
  - Reserve Microsoft extension numbers (Internal MR 1613)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.