Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix macro redefinition and include common_cmake_config.h errors #81

wants to merge 1 commit into from


Copy link

commented Jul 25, 2019

  • Build warning occurs when NOMINMAX or WIN32_LEAN_AND_MEAN is already defined
  • If the loader files are generated without cmake, common_cmake_config.h doesn't exist so its inclusion should be wrapped around a macro.

This comment has been minimized.

Copy link

commented Jul 25, 2019

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.


This comment has been minimized.

Copy link

commented Aug 1, 2019

This looks great, I'd love to merge it once you do the CLA.

@rpavlik rpavlik self-requested a review Aug 1, 2019


rpavlik approved these changes Aug 1, 2019

@zheqiMicrosoft zheqiMicrosoft referenced this pull request Aug 1, 2019

This comment has been minimized.

Copy link

commented Aug 1, 2019

Thanks for the review Ryan. I'm still waiting for confirmation on whether I can sign the CLA. In the meantime, Kevin has PR up with these changes: #92

@rpavlik rpavlik referenced this pull request Aug 2, 2019

This comment has been minimized.

Copy link

commented Aug 2, 2019

Fixed with #95

@patrto patrto closed this Aug 2, 2019

rpavlik added a commit that referenced this pull request Aug 3, 2019

OpenXR 1.0.1 release (2-August-2019)
Patch release for the 1.0 series.

### GitHub Pull Requests

These had been integrated into the public repo incrementally.

- General, Build, Other
  - #87 - Fix makefiles
  - #88 - Remove unneeded generation (corresponds to issue #74, internal issue 1139, internal MR 1491)
  - #101 - Fix install of header and loader.
- Loader
  - #91 - Fix a loader bug which prevented Layers from not implementing all XR functions
  - #95 - Guard config includes/defines (relates to #81, #92)
  - #97 - Remove a constant static std::vector, use a std::array instead.
- Layers
  - #84 - Fix Linux warning for apidump
- From OpenXR-Docs:
  - #26 - Proposal for unbounded space and spatial anchor extensions (vendor extensions)

### Internal issues

- General, Build, Other
  - Makefile cleanups (internal MR 1469, 1489)
  - Add release scripts (internal MR 1496)
- Registry
  - Reserve Oculus extension numbers (internal MR 1493)
  - Add Monado headless (vendor extension) (internal MR 1482)
- Loader
  - Remove unnecessary `#ifdef _WIN32` in loader. (internal MR 1487)

### New extensions

- `XR_MND_headless`
- `XR_MSFT_spatial_anchor`
- `XR_MSFT_unbounded_reference_space`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
3 participants
You can’t perform that action at this time.