Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc cleanup #96

Merged
merged 6 commits into from Aug 21, 2019

Conversation

@rpavlik
Copy link
Contributor

commented Aug 2, 2019

Miscellaneous cleanup things noticed as I was working on azure-pipelines.

@rpavlik rpavlik requested review from daveh-lunarg and yl-msft Aug 2, 2019

@rpavlik rpavlik force-pushed the rpavlik:misc-cleanup branch 3 times, most recently from 787b510 to e514fb1 Aug 2, 2019

@rpavlik

This comment has been minimized.

Copy link
Contributor Author

commented Aug 2, 2019

FYI, I have removed most of the changes from this into their own separate PRs.

@daveh-lunarg
Copy link
Contributor

left a comment

LGTM

@rpavlik rpavlik force-pushed the rpavlik:misc-cleanup branch from e514fb1 to 88b5f15 Aug 21, 2019

rpavlik added some commits Jul 30, 2019

build: Banish CMAKE_SOURCE_DIR/CMAKE_BINARY_DIR
Should allow building as a subproject.

@rpavlik rpavlik merged commit 312d283 into KhronosGroup:master Aug 21, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
license/cla Contributor License Agreement is signed.
Details

@rpavlik rpavlik deleted the rpavlik:misc-cleanup branch Aug 21, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.