Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make mainfest file more compatible #43

Merged
merged 1 commit into from May 13, 2019

Conversation

Projects
None yet
5 participants
@zheqiMicrosoft
Copy link
Contributor

commented May 10, 2019

  1. Adding #include<sstream> so manifest_file.cpp can work with jsoncpp library without having to almagate the rouces together (calling src/external/jsoncpp/amalgamate.py). This is useful with chroumium where jsoncpp library is used as not almagated.

  2. Changing Json:::ValueIterator func_it-> to Json:::ValueIterator (*func_it). so it will be compatible to older version of jsoncpp library.(like the one used by chroumium now)

@CLAassistant

This comment has been minimized.

Copy link

commented May 10, 2019

CLA assistant check
All committers have signed the CLA.

@brycehutchings

This comment has been minimized.

Copy link

commented May 10, 2019

[EDIT: Disregard! I misread what repo this was in]

@yl-msft

This comment has been minimized.

Copy link
Contributor

commented May 10, 2019

Tested this change on openxr samples and it seems working fine.

@yl-msft yl-msft requested review from rpavlik, yl-msft and daveh-lunarg May 10, 2019

@rpavlik rpavlik merged commit e0c6e67 into KhronosGroup:master May 13, 2019

1 check passed

license/cla Contributor License Agreement is signed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.