Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure timestamp does not vary with timezone. #2982

Merged
merged 1 commit into from Oct 18, 2019

Conversation

@lamby
Copy link
Contributor

lamby commented Oct 17, 2019

Thanks for implementing SOURCE_DATE_EPOCH. However, I think that the timestamp you then generate using isoformat varies with the build user's timezone. This should make it use UTC instead.

@CLAassistant

This comment has been minimized.

Copy link

CLAassistant commented Oct 17, 2019

CLA assistant check
All committers have signed the CLA.

@s-perron s-perron added the kokoro:run label Oct 17, 2019
@kokoro-team kokoro-team removed the kokoro:run label Oct 17, 2019
@s-perron s-perron merged commit e8c3f9b into KhronosGroup:master Oct 18, 2019
20 checks passed
20 checks passed
CI-android CI build successful
Details
CI-check-format CI build successful
Details
CI-macos-clang-debug CI build successful
Details
CI-macos-clang-release CI build successful
Details
CI-macos-clang-release-bazel CI build successful
Details
CI-ndk-build CI build successful
Details
CI-shaderc-smoketest CI build successful
Details
CI-ubuntu-clang-asan CI build successful
Details
CI-ubuntu-clang-debug CI build successful
Details
CI-ubuntu-clang-release CI build successful
Details
CI-ubuntu-clang-release-bazel CI build successful
Details
CI-ubuntu-gcc-debug CI build successful
Details
CI-ubuntu-gcc-release CI build successful
Details
CI-windows-VS2013-release CI build successful
Details
CI-windows-VS2015-release CI build successful
Details
CI-windows-VS2017-debug CI build successful
Details
CI-windows-VS2017-release CI build successful
Details
CI-windows-msvc-2015-release-bazel CI build successful
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
license/cla Contributor License Agreement is signed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.