-
Notifications
You must be signed in to change notification settings - Fork 547
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
spirv-val, core: add support for OpExtInstWithForwardRefs #5698
Conversation
This commit adds validation and support for OpExtInstWithForwardRefs. This new instruction will be used for non-semantic debug info, when forward references are required. For now, this commit only fixes the code to handle this new instruction, and adds validation rules. But it does not add the pass to generate/fix the OpExtInst instruction when forward references are in use. Such pass would be useful for DXC or other tools, but I wanted to land validation rules first. This commit also bumps SPIRV-Headers to get this new opcode. Signed-off-by: Nathan Gauër <brioche@google.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some of the changes in the folding rules should be reverted. Some instructions like FMix and FClamp should not have forward references, so I don't think you should change checks specifically related to those, and other like them.
Alan or someone else should look at the validator code.
Signed-off-by: Nathan Gauër <brioche@google.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Steven to approve the optimizer changes.
Merging '6a2bdee' from http://github.com/KhronosGroup/SPIRV-Tools.git This merge is required to address an issue KhronosGroup#4304. > commit 6a2bdee > Author: Nathan Gauër <brioche@google.com> > Date: Tue Jun 4 16:18:06 2024 +0200 > spirv-val, core: add support for OpExtInstWithForwardRefs (KhronosGroup#5698)
This commit adds validation and support for
OpExtInstWithForwardRefs. This new instruction will be used for non-semantic debug info, when forward references are required.
For now, this commit only fixes the code to handle this new instruction, and adds validation rules. But it does not add the pass to generate/fix the OpExtInst instruction when forward references are in use. Such pass would be useful for DXC or other tools, but I wanted to land validation rules first.
This commit also bumps SPIRV-Headers to get this new opcode.