Skip to content
This repository has been archived by the owner on Jul 19, 2018. It is now read-only.

No warning for VkViewport.minDepth > maxDepth #2224

Closed
hrydgard opened this issue Nov 21, 2017 · 5 comments
Closed

No warning for VkViewport.minDepth > maxDepth #2224

hrydgard opened this issue Nov 21, 2017 · 5 comments
Assignees
Milestone

Comments

@hrydgard
Copy link

hrydgard commented Nov 21, 2017

Calling vkCmdSetViewport with a minDepth with a greater value than the maxDepth appears to fail silently on at least AMD boards, resulting in wrong rendering output. It's unclear to me whether it's valid or not, the spec doesn't seem to say more on the subject than:

minDepth must be between 0.0 and 1.0, inclusive
maxDepth must be between 0.0 and 1.0, inclusive

So either this should be an error, maybe a warning, or I should try to report a driver bug to AMD. The latter I guess since the spec doesn't actually say that it has to be smaller? AMD has long had the same behaviour in D3D11 and D3D9, although in OpenGL it does work to reverse them.

@mark-lunarg mark-lunarg self-assigned this Nov 21, 2017
@mark-lunarg mark-lunarg added this to the P1 milestone Nov 21, 2017
@krOoze
Copy link
Contributor

krOoze commented Nov 22, 2017

Actually the minDepth and maxDepth is not checked at all.
IIRC inversed minDepth and maxDepth is valid though

@krOoze
Copy link
Contributor

krOoze commented Nov 22, 2017

Yes, indeed the specification does say:

It is valid for minDepth to be greater than or equal to maxDepth.

@hrydgard
Copy link
Author

Oh right, I missed that. Then, I'd guess that this case is missing in the Vulkan conformance tests, because both AMD and older Mali drivers misbehave badly with minDepth > maxDepth. What's the best place to report or contribute missing conformance test cases?

I'll try to get around to reporting this to AMD in the near future. Feel free to close.

@krOoze
Copy link
Contributor

krOoze commented Nov 22, 2017

I would assume the Vulkan CTS repo.
AMD Issues probably through Radeon Settings->Preferrences->Report Issues Online. Or AMD Dev forum.
I don't know Mali, but knowing Android it won't get fixed for a year if ever.

BTW, you can self-close on GitHub.

@hrydgard
Copy link
Author

Turns out it's actually already tested - but the test was added quite recently, which would explain the failures: KhronosGroup/VK-GL-CTS#44

It's fixed in newer Mali driver versions - S8 has the fix, Xiaomi doesn't.

Yeah I know I can close, project policies for who closes tend to differ though :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants