Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update secondary command buffer's initial layout map #1035

Merged
merged 1 commit into from Jul 3, 2019

Conversation

Projects
None yet
2 participants
@mark-lunarg
Copy link
Collaborator

commented Jul 3, 2019

When image layout state data was propagated to secondary command buffers, the initial layout state map was not updated, resulting in stale data which led to segmentation faults.

Fixes #1011.

corechecks: Update 2ndary cmdbufs initial layout map
When image layout state data was propagated to secondary command
buffers, the initial layout state map was not updated, resulting
in stale data which caused segmentation faults.

Change-Id: I2e72887f47c5d6dba4253270a2154146cee75a8f

@mark-lunarg mark-lunarg added the bug label Jul 3, 2019

@mark-lunarg mark-lunarg added this to the P1 milestone Jul 3, 2019

@mark-lunarg mark-lunarg requested a review from jzulauf-lunarg Jul 3, 2019

@mark-lunarg mark-lunarg self-assigned this Jul 3, 2019

@jzulauf-lunarg
Copy link
Contributor

left a comment

Ship it!

@@ -753,6 +753,7 @@ class ImageSubresourceLayoutMapImpl : public ImageSubresourceLayoutMap {
bool updated = false;
updated |= layouts_.initial.Merge(from.layouts_.initial);
updated |= layouts_.current.Merge(from.layouts_.current);
initial_layout_state_map_.Merge(from.initial_layout_state_map_);

This comment has been minimized.

Copy link
@jzulauf-lunarg

jzulauf-lunarg Jul 3, 2019

Contributor

👍

@mark-lunarg mark-lunarg merged commit 22cbd2d into master Jul 3, 2019

3 of 4 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@mark-lunarg mark-lunarg deleted the markl-secondaryimagelayouts-1011 branch Jul 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.