Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support new Emission Strength on Principled BSDF #1216

Closed
emackey opened this issue Sep 17, 2020 · 6 comments
Closed

Support new Emission Strength on Principled BSDF #1216

emackey opened this issue Sep 17, 2020 · 6 comments
Labels
enhancement New feature or request exporter This involves or affects the export process importer This involves or affects the import process Material

Comments

@emackey
Copy link
Member

emackey commented Sep 17, 2020

A new Emission Strength input was added to the Principled BSDF node in D4971.

Emission strength from the original Emission BSDF node was added in #1159. It should be updated to include the new strength input as well.

@emackey
Copy link
Member Author

emackey commented Sep 17, 2020

Ah, correction: #1159 already includes code to look for emission strength on Principled BSDF. We should add test(s) for this once we get a daily build with the new input added.

@julienduroure
Copy link
Collaborator

julienduroure commented Sep 17, 2020

So, seems exporter already manage it (to be tested with tomorrow's build)
Importer still need to be updated?

@julienduroure julienduroure added this to the Blender 2.91 milestone Sep 17, 2020
@julienduroure julienduroure added enhancement New feature or request exporter This involves or affects the export process importer This involves or affects the import process Material labels Sep 17, 2020
@scurest
Copy link
Contributor

scurest commented Sep 18, 2020

Emission Strength is now in the latest build. I can confirm exporting works.

The importer can use the strength socket for grayscale emissiveFactors at least.

@KenzieMac130
Copy link

Hi! Author of the Emission Strength Socket patch.

https://developer.blender.org/D8777 is needed to access the socket via python using the Principled BSDF wrangler. It is in review but the API should remain the same.

You can find the WIP updated OBJ importer here which contains code to handle importing/exporting emission strength by doing a sort of RGBM encoding/decoding. https://developer.blender.org/D8868

Thanks

@julienduroure
Copy link
Collaborator

Hello @astrand130 , current implementation of glTF is not using node_shader_utils wrangler.

Exporting is already manage since yesterday, and importer will be via #1217

@julienduroure
Copy link
Collaborator

Import part is now merge. Closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request exporter This involves or affects the export process importer This involves or affects the import process Material
Projects
None yet
Development

No branches or pull requests

4 participants