Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minimal support of vertex colors #1678

Merged
merged 6 commits into from Jul 13, 2022
Merged

Minimal support of vertex colors #1678

merged 6 commits into from Jul 13, 2022

Conversation

julienduroure
Copy link
Collaborator

@julienduroure julienduroure commented Jun 30, 2022 •
edited

Waiting big refactoring, here is a minimal PR to get COLOR_0 working

@julienduroure julienduroure marked this pull request as ready for review June 30, 2022 16:32
@julienduroure
Copy link
Collaborator Author

Here is a simple fix for new attribute management, after changes on 3.2
This is a minimal support of active vertex color, waiting a complete refactoring of attributes on #1676

Any feedback welcome

@julienduroure julienduroure changed the title export active vertex color as COLOR_0 Minimal support of vertex colors Jul 7, 2022
@julienduroure
Copy link
Collaborator Author

I added support of "Color" data type, and "POINT" domain.
Now I think we have correct vertex color management (without other attributes management).

I proposed to merge this PR for 3.3, and waiting other PR #1676 to be ready, so probably for 3.4

@julienduroure
Copy link
Collaborator Author

Any feedback @scurest ?

@julienduroure julienduroure added this to the Blender 3.3 milestone Jul 7, 2022
@julienduroure julienduroure merged commit e8529b6 into master Jul 13, 2022
2 checks passed
@julienduroure julienduroure deleted the export_active_vertex_color branch July 13, 2022 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Blender 3.3
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@julienduroure