Check for missing textures and unassigned shader nodes #559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@julienduroure This is ready to merge, it's just some guards against |
donmccurdy
approved these changes
Jul 26, 2019
|
I'm assuming this will need to go into 2.81 at this point, but the changes look good to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
We were already printing a warning message, but then crashed. This should protect against the crashes.
Also, added a new test scene that has a missing PNG file and an Image Texture shader node that is not assigned an image. No specific test code is needed, we just allow the normal test suite functionality to test whether this crashes on export (which would fail the test).
Fixes #345, fixes #543 ... like a palindrome