Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export named vertex attribute sets as custom attributes. #807

Draft
wants to merge 2 commits into
base: master
from

Conversation

@donmccurdy
Copy link
Member

donmccurdy commented Nov 30, 2019

Proposed fix for #542.

Not ready to merge – there's one TODO in the code, and I'd like to get more feedback on whether this is the right approach and whether it's useful.

Steps to test:

  1. Create one or more vertex color sets.
  2. Assign a custom (non-"Col") name to at least one vertex color set.
  3. Export with the "Meshes -> Custom Attributes" option enabled.
  4. Result should be something like this, given a vertex color set named "Flux":

Screen Shot 2019-11-29 at 10 49 32 PM

Screen Shot 2019-11-29 at 10 45 06 PM

This will import to three.js with the name mesh.geometry.attributes._flux, for example.

@julienduroure

This comment has been minimized.

Copy link
Collaborator

julienduroure commented Nov 30, 2019

I fixed tests (download daily build was KO), so you should merge master to re-run tests

@donmccurdy donmccurdy force-pushed the donmccurdy:feat-custom-attributes branch from c911f46 to e87c462 Nov 30, 2019
@donmccurdy

This comment has been minimized.

Copy link
Member Author

donmccurdy commented Dec 2, 2019

Maybe this feature should use Weight Painting instead of vertex colors... 🤔

@mgsx-dev

This comment has been minimized.

Copy link

mgsx-dev commented Dec 12, 2019

i'm wondering why limit exported color layers count. Master branch limits to 2 and current PR limits to 4.

Is there any reason to have a limit? and have it hard coded?

If so maybe we could at least log a warning during export.

@donmccurdy

This comment has been minimized.

Copy link
Member Author

donmccurdy commented Dec 24, 2019

Yeah, I'm not sure why there's a limit at all... I'd be fine with removing that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.