New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
About normalization #5
Comments
Thanks for spotting this! This is indeed an oversight on my part. |
I'm retraining with the correct |
Hello all, first of all, thank you for publishing the code, which is very helpful for the community! I can only partially agree with this, as the calculated anchor point for the proposed normalisation and calculation of the prediction does have an influence on the prediction. For example, the ETH scene has many 1-person trajectories. Considering that the history consists of 8 time steps and the prediction of 12, the anchor point may well contain information about where the person might be in the future. This is not the case with the Univ dataset with many people in one scene. I have retrained the models with AgentFormer/model/agentformer.py Line 535 in cf13e40
self.data['scene_orig'] = self.data['pre_motion'].view(-1, 2).mean(dim=0) Scene | ADE/FDE I still find the results very good and very similar to the Trajectron++. I think that the result on the dataset is almost perfect and I don't think that the result can be improved by more than 5%. For the NuScenes dataset I have the problem that I could not reproduce the published results with the proposed (wrong anchor point) using the available script, which i had not for ETH/UTC. I followed all the instructions and downloaded the entire NuScenes dataset and converted it to a file of about 56 MB with the preprocessing script. When I use the model published by you, I get the result in the paper, but unfortunately not when I train it myself. Am I doing something wrong or is there something wrong with the config file? Here are the results for NuScenes-5samples: Model | ADE\FDE Again very similar to the Trajectron, but I hope that there is something wrong with the config file and that I can get much better results. Many greetings, |
Hi @Mirorrn , Thank you for your detailed analysis! I will keep investigating this error, and update the paper with the correct numbers. One thing you may want to try is to change the anchor point to
So that it will use For the nuScenes dataset, I haven't retrained the model yet, but I will retrain it soon with the correct anchor. It could be there is something wrong with the configs or something is changed during the code cleaning process. Thanks! |
Hi, unfortunately I have no time this week to test it with t=0 as anchor point. Many greetings |
Hi Mirrorn, I’m actively running experiments and hopefully will have updates soon. Thanks again for your help! |
Sorry for the late update. I was busy with a deadline. |
I will close this issue for now, but if anything else comes up, please let me know. |
Hi, I have noticed that in the code (
AgentFormer/model/agentformer.py
Line 535 in cf13e40
The text was updated successfully, but these errors were encountered: