Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
RJ45: Add a new Amphenol RJHSE5380-08 footprint #1300
No it isn't, however, please indicate path in the footprint (name of 3D = name of footprint, look at other devices) so it is possible to create it later without to come back to the definition of the footprint.
For reference the screenshot of the part:
The datasheet (dimensioned drawing) https://www.amphenolcanada.com/ProductSearch/drawings/AC/RJHSE538X08.pdf
@manio please provide these two in the future.
The courtyard must take all pads into account. (All shield pads in your case)
You have the same pin numbers added multiple times. This will mean you can not connect the connectors independently but only in parallel. I doubt this would be on purpose.
I hope it is now OK for you - so please review again. Thank you in advance! :)
We use the squash option to merge pull requests (if there are many commits by the contributor). Github offers an easy interface for that.
We also use that to clean up commit messages by contributors. (Most contributors don't really have any experience with git. Meaning they do not really know how to write proper messages.)