RJ45: Add a new Amphenol RJHSE5380-08 footprint #1300
No it isn't, however, please indicate path in the footprint (name of 3D = name of footprint, look at other devices) so it is possible to create it later without to come back to the definition of the footprint.
For reference the screenshot of the part:
The datasheet (dimensioned drawing) https://www.amphenolcanada.com/ProductSearch/drawings/AC/RJHSE538X08.pdf
@manio please provide these two in the future.
The courtyard must take all pads into account. (All shield pads in your case)
You have the same pin numbers added multiple times. This will mean you can not connect the connectors independently but only in parallel. I doubt this would be on purpose.
I hope it is now OK for you - so please review again. Thank you in advance! :)
We use the squash option to merge pull requests (if there are many commits by the contributor). Github offers an easy interface for that.
We also use that to clean up commit messages by contributors. (Most contributors don't really have any experience with git. Meaning they do not really know how to write proper messages.)
* 'master' of github.com:KiCad/kicad-footprints: (39 commits) Crystal: Add Abracon ABS25 4Pin 8.0x3.8mm (KiCad#1270) RJ45: Add a new Amphenol RJHSE5380-08 footprint (KiCad#1300) Add DFN-10 with EP 1.2x2 (KiCad#1290) Seiko ms621 f (KiCad#1218) Sip package link fixes (KiCad#1215) RF Module: Add CMWX1ZZABZ (KiCad#1296) Add L_Wuerth_WE-PD-Typ-7345. (KiCad#1299) Converter_DCDC XP_POWER IA, IH, ITX and ITQ series (KiCad#1058) More 3M Textool ZIF sockets, generated with script. (KiCad#495) Changed courtyard clearance to 0.25mm. Added Kyocera 6 pin tcxo. Add JST PHD series of connector footprints (KiCad#915) Rename Cherry MX1A to Cherry MX (KiCad#1180) RF_Module: Fix and improves HOPERF_RFM9XW_SMD footprint (KiCad#1213) Add vertical USB Type-C DX07S024WJ1 (KiCad#1251) Add PAT1220 RF attenuator. (KiCad#1288) Add RJ45_BEL_SS74301-00x (KiCad#1036) Add Texas R-PUQFN-N10 (KiCad#1310) Add LairdTech_28C0236-0JW-10 Ferrite bead (KiCad#1040) Fix courtyard and silkscreen ...