Conversation
Add Belton Reverb BTDR-1H and BTDR-1V footprints. http://www.belton.co.kr/inc/downfile.php?seq=17&file=pdf
Add Reverb Belton BTDR-1H and Belton BTDR-1V http://www.belton.co.kr/inc/downfile.php?seq=17&file=pdf
mod error after Travis report
Update keywords
Thanks for your submission. This footprint has been added to a new library called I'll continue reviewing in the meantime. Thanks! |
Hello, Thks |
Add that change to this same PR. Thanks! |
Hello, |
Hello, |
That is correct. It needs to be changed to whichever name is agreed.
@evanshultz, @poeschlr: what do you think about this one?
For the rest of stuff I can open an issue for v6 if you think so. Thanks! |
Regarding this, I've just noticed that it's the same for USB connectors: symbol on |
@evanshultz, @poeschlr: any preference on what library name to use for this one? Thanks. |
What is the symbol library called? Might be best to go with a similar name as this device is highly specialized. (Both symbol and footprint are specialized to this exact device -> atomic pairing) |
The symbol, on KiCad/kicad-symbols#1486, is simply using |
Hello, |
Personally, I would go for On the symbol side, we've got On the footprint side, Could you make those changes? Thanks! |
Hi @McColson, are you available to make the renames for the module name @diegoherranz requested? I saw the 3D modules PR that is linked to this and wanted to see if you were interested in pursuing getting them merged in after review. Apologizes for the delay, we have lots of requests and not so many people reviewing changes. |
Hello, |
Update 2/5/2020
Add new Audio_Module library for Belton Reverb Module Remove old naming
Change the 3d model path
Add Audio_Module.pretty to receive the Belton Reverb Module
Hello, I've tried to finished the job for this PR.
Hope that all this mods can complete the PR. Thanks. |
Thanks, @McColson, I'll review as soon as possible. |
Hello, |
Change F.Fab and F.CrtYd layers
MAJ 31/05/2020
Hello,
BTDR1-H
BTDR1-V
I hope, that will be good this time, sorry for the time you spent on this PR. |
Thanks for all the changes. There will be a lockdown and move of the library repos to gitlab, so I'd like to get this PR completed before that happens (see the README on https://github.com/KiCad/kicad-symbols for more info).
That sounds OK
That drawing makes more sense (both vertical and horizontal having the same X coordinates.
I think that would be it. Thanks again! |
Hello, i try to do this asap. Thx |
@McColson ping |
Sorry no more time for the moment to work on it 😥 |
No problem, thanks for the answer. I indicate that for the moment it is Abandoned but you or anyone else can comme back to this PR later. |
There was so little pending fixing that I've just done a quick couple of commits since I didn't want the work on this pull request to get lost. Merging. |
I missed one of my own review comments:
So I've created #2493 to fix it. |
Add Digital Reverb Belton BTDR-1H and BTDR-1V footprints
http://www.belton.co.kr/inc/downfile.php?seq=17&file=pdf
Symbol request
KiCad/kicad-symbols#1486
All contributions to the kicad library must follow the KiCad library convention
Thanks for creating a pull request to contribute to the KiCad libraries! To speed up integration of your PR, please check the following items: