Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add switch KMR2 with ground pin #1639

Open
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@mibe
Copy link
Contributor

commented Jun 10, 2019

CK KMR2 tactile push button with ground pin

There's a version of the (already existing) KMR2 push button in the Button_Switch_SMD library with ground pin, which is added here.
Datasheet, see page 2

I wasn't sure which name to use for that pin, so I left it empty, just like in footprint SW_SPDT_PCM12.

KMR2xxG


All contributions to the kicad library must follow the KiCad library convention

Thanks for creating a pull request to contribute to the KiCad libraries! To speed up integration of your PR, please check the following items:

  • Provide a URL to a datasheet for the footprint(s) you are contributing
  • An example screenshot image is very helpful
  • If there are matching symbol or 3D model pull requests, provide link(s) as appropriate
  • Check the output of the Travis automated check scripts - fix any errors as required
  • Give a reason behind any intentional library convention rule violation.
@antoniovazquezblanco

This comment has been minimized.

Copy link
Member

commented Jun 11, 2019

I believe that the ground pin is shielding. We should probably use SH for the ground pad name in order to be able to connect that pad to any other signal. Maybe other librarians may prefer MP for mounting pad. When a reviewer is assigned to your PR, the reviewer will help you with the naming.

Thanks!

@mibe

This comment has been minimized.

Copy link
Contributor Author

commented Jun 11, 2019

Should the footprint without the ground pin renamed to SW_Push_1P1T_NO_CK_KMR2xxNG as per datasheet?

@antoniovazquezblanco

This comment has been minimized.

Copy link
Member

commented Jun 12, 2019

I think so but it would probably be a good idea to do it in a separate PR just in case lead librarians want to merge it in the V6 release cycle.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.