Mini-Circuits footprint HQ1157

[aewallin]

https://www.minicircuits.com/case_style/HQ1157.pdf
Used in KiCad/kicad-symbols#2604

---

All contributions to the kicad library must follow the KiCad library convention

Thanks for creating a pull request to contribute to the KiCad libraries! To speed up integration of your PR, please check the following items:

• Provide a URL to a datasheet for the footprint(s) you are contributing
• An example screenshot image is very helpful
• If there are matching symbol or 3D model pull requests, provide link(s) as appropriate
• Check the output of the Travis automated check scripts - fix any errors as required
• Give a reason behind any intentional library convention rule violation.

---

Be patient, we maintainers are volunteers with limited time and need to check your contribution against the datasheet. You can speed up the process by providing all the necessary information (see above). And you can speed up the process even more by providing a dimensioned drawing of your contribution. A tutorial on how to do that is found here: https://forum.kicad.info/t/how-to-check-footprint-correctness/9279 (This is optional!)

[chschlue]

• Please rotate 90° CW
• Dimension A is wrong
• Use metric units

Full review to follow.

[aewallin]

• rotated the footprint
• I don't understand which dimension is wrong
• The datasheet gives even numbers in inches. Insisting on metric just leads to a lot of rounding issues. For example do you consider A=9.271 mm to be correct - or A=9.27mm as in the datasheet?

[chschlue]

• rotated the footprint

Rotated by -100^g, check :)

• I don't understand which dimension is wrong

Never mind, don't know what I did there.

• The datasheet gives even numbers in inches. Insisting on metric just leads to a lot of rounding issues. For example do you consider A=9.271 mm to be correct - or A=9.27mm as in the datasheet?

Neither is "correct" and both are within the tolerance given. We usually prefer metric because that's what's used under the hood anyway.
But I agree, rounding errors keep adding up in this case, so forget it.