This repository has been archived by the owner. It is now read-only.

Silabs klc fixups #1088

Merged
merged 5 commits into from Mar 5, 2017

Conversation

Projects
None yet
2 participants
@bradfa
Contributor

bradfa commented Mar 5, 2017

Fixup all KLC violations, including extra checking ones.

bradfa added some commits Mar 4, 2017

silabs: CP2112: fix KLC violations
Switched VBUS to be an input pin, both suspend pins to be outputs, and
all GND pins to be power inputs as per the CP2112 datasheet.

Prior to fixing, KLC violations were:
checking component: CP2112
  Violating Rule 3.9
    For components with a single default footprint, footprint field is filled with valid footprint
    filename
  Violating EC01 - Extra Checking
    Check pins names against pin types.
  Violating EC03 - Extra Checking
    Check part reference, name and footprint position and alignment
  Violating EC04 - Extra Checking
    Check line width and background for box outlines parts.

Signed-off-by: Andrew Bradford <andrew@bradfordembedded.com>
silabs: Si4362: Fix KLC violations, add ground pad pin
Add pin 21 ground pad.

Prior to fixing, violations were:
checking component: Si4362
  Violating Rule 3.8
    Description and keywords properties contains information about the component.
  Violating EC01 - Extra Checking
    Check pins names against pin types.
  Violating EC03 - Extra Checking
    Check part reference, name and footprint position and alignment
  Violating EC04 - Extra Checking
    Check line width and background for box outlines parts.
  Violating EC05 - Extra Checking
    Pin numbers should not be duplicated, and all pins should be present
    Pin 4 is missing
    Pin 5 is missing
    Pin 7 is missing

Signed-off-by: Andrew Bradford <andrew@bradfordembedded.com>
silabs: CP2102N-A01-CQFN24: fix KLC violations
Before fixing, violations were:
checking component: CP2102N-A01-GQFN24
  Violating EC03 - Extra Checking
    Check part reference, name and footprint position and alignment

Signed-off-by: Andrew Bradford <andrew@bradfordembedded.com>
silabs: CP2104: Fix KLC violations
Before fixing, violations were:
checking component: CP2104
  Violating EC03 - Extra Checking
    Check part reference, name and footprint position and alignment

Signed-off-by: Andrew Bradford <andrew@bradfordembedded.com>
silabs: Si4735-D60-GU: Move NC pins, fix KLC violations
Move NC pins to not be at the same coordinates as GND pins.

Before fixing violations, they were:
checking component: Si4735-D60-GU
  Violating EC01 - Extra Checking
    Check pins names against pin types.

Signed-off-by: Andrew Bradford <andrew@bradfordembedded.com>
@SchrodingersGat

This comment has been minimized.

Contributor

SchrodingersGat commented Mar 5, 2017

Great, thanks :)

@SchrodingersGat SchrodingersGat merged commit e79e02a into KiCad:master Mar 5, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.