Skip to content
This repository has been archived by the owner on Oct 2, 2020. It is now read-only.

Move CH376 from Memory_Controller to to Interface (#1144) #1176

Merged
merged 1 commit into from Mar 11, 2019

Conversation

antoniovazquezblanco
Copy link
Collaborator

Re push of #1144 now targeting a future release to avoid breaking the libs in a minor release.

Related to issue #18.

Details:

  • Move CH376 from Memory_Controller to to Interface
  • Interface: Change pin name offset in CH376
  • Interface: Fix CH376T pin types and description

* Move CH376 from Memory_Controller to to Interface

* Interface: Change pin name offset in CH376

* Interface: Fix CH376T pin types and description
@antoniovazquezblanco antoniovazquezblanco added the Enhancement Improves existing symbol in the library label Nov 26, 2018
@antoniovazquezblanco antoniovazquezblanco added this to the 5.1.0 milestone Nov 26, 2018
@antoniovazquezblanco
Copy link
Collaborator Author

Closed & reopened for CLA.

@poeschlr I would like to get your input on when to merge this. Would you like to go 5.1.0 or 6.0.0?

Thanks!

@evanshultz
Copy link
Collaborator

@poeschlr
Ping!

@myfreescalewebpage myfreescalewebpage added the Pending reviewer A pull request waiting for a reviewer label Jan 11, 2019
@myfreescalewebpage myfreescalewebpage removed this from the 5.1.0 milestone Jan 29, 2019
@antoniovazquezblanco antoniovazquezblanco added this to the 6.0.0 milestone Feb 11, 2019
@evanshultz
Copy link
Collaborator

@poeschlr
5.1 or 6?

@antoniovazquezblanco
Copy link
Collaborator Author

V6 window open!

@evanshultz evanshultz self-assigned this Mar 11, 2019
@evanshultz evanshultz merged commit e0139d2 into KiCad:master Mar 11, 2019
@antoniovazquezblanco antoniovazquezblanco deleted the dev/ch376 branch March 11, 2019 16:29
@antoniovazquezblanco
Copy link
Collaborator Author

Thanks!

@poeschlr
Copy link
Collaborator

This one sadly needs to be reverted as we can not delete a library in the middle of a release cylce.
Sorry about the inconvenience.

poeschlr added a commit that referenced this pull request Apr 14, 2019
poeschlr added a commit that referenced this pull request Apr 14, 2019
DaToBSn pushed a commit to DaToBSn/kicad-symbols that referenced this pull request Jul 2, 2019
* 'master' of github.com:KiCad/kicad-symbols: (228 commits)
  Added alias for MS5607 pressure sensor
  Fixed pin stacking
  Fix pin names
  Changes as requested
  Shrink pin length and number for small gnd crystals
  Save Device lib
  Update LT3010 with proper naming (KiCad#1458)
  Move CH376 from Memory_Controller to to Interface (KiCad#1144) (KiCad#1176)
  Add SSOP to fp-filter
  Add PIC18(L)F25/26K83 in DIP-28 (KiCad#1120)
  Address review comments for PocketBeagle
  - uploaded dcm for fixing description
  Fixed footprint filter
  - fixed footprint name in filter and description
  Added 2N7002K (KiCad#1615)
  Add PocketBeagle
  Implemented changes
  Implemented changes
  - added description to aliases
  - fixed naming - changed package from LQFP-64 to TQFP-64_10x10mm_P0.5mm - changed pin name offset to 20mil - changed pin length to 1000mil - removed stacking of positive power pin stacking - changed name of pin 21 from VDDIO to VDDIOB - fixed RESET pin name - moved reset pin to bottom left corner - VDDCORE -> Power Input - VSW -> Power Input (moved to the top of the symbol)
  ...
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Enhancement Improves existing symbol in the library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants