Skip to content
This repository has been archived by the owner on Oct 2, 2020. It is now read-only.

Adding 93AAxxAT-xOT and 93AAxxBT-xOT #2206

Merged
merged 3 commits into from Oct 7, 2019
Merged

Adding 93AAxxAT-xOT and 93AAxxBT-xOT #2206

merged 3 commits into from Oct 7, 2019

Conversation

ki5libs
Copy link
Contributor

@ki5libs ki5libs commented Sep 26, 2019

Adding 93AAxxAT-xOT and 93AAxxBT-xOT - SOT-23-6 version of 93AAxxA symbol
Datasheet

93AAxxAT-xOT


All contributions to the kicad library must follow the KiCad library convention

Thanks for creating a pull request to contribute to the KiCad libraries! To speed up integration of your PR, please check the following items:

  • Provide a URL to a datasheet for the symbol(s) you are contributing
  • An example screenshot image is very helpful
  • Ensure that the associated footprints match the official footprint library
    • A new fitting footprint must be submitted if the library does not yet contain one.
  • If there are matching footprint PRs, provide link(s) as appropriate
  • Check the output of the Travis automated check scripts - fix any errors as required
  • Give a reason behind any intentional library convention rule violation.

@diegoherranz diegoherranz added Addition Adds new symbols to library Pending reviewer A pull request waiting for a reviewer labels Sep 26, 2019
@cpresser
Copy link
Contributor

cpresser commented Oct 5, 2019

  • Filter should be SOT?23* like other parts in the lib:
    image
  • The FP-name in the description should have the -6 suffix.
  • The pin positions do not conform to KLC. But they are the same as the existing symbols. And the user should be able to use this one as a drop-in-replacement. So its okay.

@ki5libs
Copy link
Contributor Author

ki5libs commented Oct 7, 2019

Hi @cpresser,

it's fixed now.

@cpresser cpresser merged commit 09a001e into KiCad:master Oct 7, 2019
@antoniovazquezblanco antoniovazquezblanco removed the Pending reviewer A pull request waiting for a reviewer label Oct 8, 2019
@antoniovazquezblanco antoniovazquezblanco added this to the 5.1.5 milestone Oct 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Addition Adds new symbols to library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants