Skip to content
This repository has been archived by the owner on Oct 2, 2020. It is now read-only.

Added AP2112K as alias to AP2204K #860

Merged
merged 2 commits into from Sep 13, 2018
Merged

Conversation

UlfWetzker
Copy link
Contributor

@UlfWetzker UlfWetzker commented Aug 29, 2018

Added the 600mA LDO regulator AP2112K as an alias to the component AP2204K.
https://www.diodes.com/assets/Datasheets/AP2112.pdf

ap2112k

Thanks for creating a pull request to contribute to the KiCad libraries! To speed up integration of your PR, please check the following items:

  • Provide a URL to a datasheet for the symbol(s) you are contributing
  • An example screenshot image is very helpful
  • Ensure that the associated footprints match the official footprint library
  • If there are matching footprint PRs, provide link(s) as appropriate
  • Check the output of the Travis automated check scripts - fix any errors as required

@CLAassistant
Copy link

CLAassistant commented Aug 29, 2018

CLA assistant check
All committers have signed the CLA.

@UlfWetzker UlfWetzker closed this Aug 29, 2018
@UlfWetzker UlfWetzker deleted the AP2112K branch August 29, 2018 21:08
@UlfWetzker UlfWetzker restored the AP2112K branch August 29, 2018 21:08
@UlfWetzker UlfWetzker reopened this Aug 29, 2018
@Ratfink
Copy link
Collaborator

Ratfink commented Aug 31, 2018

Thanks for the contribution!

Overall this looks good, but I'm not sure "wide input voltage range" is accurate for a part whose recommended supply voltage 2.5 V–6.0 V. Change the descriptions to either remove that or include a correct range (taking into account the maximum dropout voltage for each part), and I think this will be ready to merge.

@UlfWetzker
Copy link
Contributor Author

Thank you for your feedback.
I just copied "wide input voltage range" form to product description and you are right this information is not useful at all.

I changed it to the correct input voltage ranges incl. the dropout voltage.

@SchrodingersGat
Copy link
Contributor

Thanks @UlfWetzker for your contribution :)

@SchrodingersGat SchrodingersGat merged commit 488b225 into KiCad:master Sep 13, 2018
@myfreescalewebpage myfreescalewebpage added the Addition Adds new symbols to library label May 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Addition Adds new symbols to library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants