New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Add review webhooks #78

Merged
merged 5 commits into from Feb 23, 2017

Conversation

Projects
None yet
2 participants
@Thatkookooguy
Copy link
Member

Thatkookooguy commented Feb 23, 2017

Change Summary

  • assignees now populate the assignees attribute instead of the reviewers attribute on a pullRequest
  • integrated 2 new github pull_request events [resolves #29]
    • review_requested - adds a reviewer to the pullRequest data
    • review_request_removed - removes a reviewer and adds him to the history. history for removed reviewers is not unique. that's because the same reviewer can be removed multiple times
  • integrated 3 new github pull_request_review_comment events [resolves #29]
    • created - new review comment. add it to the reviewComments attribute.
    • deleted - deleted a review comment. removes it from the reviewComments attribute, and adds an history item inside history.reviewComments.deleted with the comment id
    • edited - changes the comment in reviewComments, and adds an history item inside history.reviewComments[<comment_id>] with the old message body
  • integrated 1 new github pull_request_review events [resolves #29]
    • submitted - reviewer submitted their review. this is populated in the reviews attribute. This holds all reviews by all users. reviews can't be changes, so every pull request review submits a new one and adds it to the array.

More info

right now, pull request review comments might appear twice! once in reviewComments and once in inlineComments. So achievements that want to check all comments should go to inlineComments and ignore reviewComments. reviewComments should be used for achievements that focus on code reviews.

tests will be implemented in a different PR

Thatkookooguy added some commits Feb 7, 2017

Add events for CR
At this stage they do nothing. They should write data on the pull request object
@coveralls

This comment has been minimized.

Copy link

coveralls commented Feb 23, 2017

Coverage Status

Coverage decreased (-3.9%) to 39.885% when pulling 9f742ad on feature-add-review-webhooks into 2b5fa29 on master.

@coveralls

This comment has been minimized.

Copy link

coveralls commented Feb 23, 2017

Coverage Status

Coverage decreased (-3.9%) to 39.885% when pulling bb369c0 on feature-add-review-webhooks into 2b5fa29 on master.

@Thatkookooguy

This comment has been minimized.

Copy link
Member

Thatkookooguy commented Feb 23, 2017

@ortichon I'll try and add tests on a different PR. I want to get this in so we can continue with other things

@Thatkookooguy Thatkookooguy merged commit e6128bd into master Feb 23, 2017

2 of 3 checks passed

coverage/coveralls Coverage decreased (-3.9%) to 39.885%
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@Thatkookooguy Thatkookooguy deleted the feature-add-review-webhooks branch Nov 6, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment