New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OAuth server side functions #96

Merged
merged 30 commits into from Sep 29, 2017

Conversation

2 participants
@Thatkookooguy
Copy link
Member

Thatkookooguy commented Aug 4, 2017

Change Summary

currently the changes are made only on the server side

since our client is dumb, we need to add lot on the client so I'm doing that on a different PR

  • added some server side features for oAuth [related to #55]

introduced some bad code here, but since this is still a WIP, and since this feature is starting to be pretty big for a single PR, I'm going to continue refactoring this in future PR related as well to this feature

Thatkookooguy added some commits Aug 4, 2017

create two api end-points
one to authenticate and another one to create\delete webhooks

(currently I'm sending the githubToken to the client and it sends it back when creating a webhook. need to keep only the firebaseToken on the client side
@coveralls

This comment has been minimized.

Copy link

coveralls commented Aug 4, 2017

Coverage Status

Coverage decreased (-30.2%) to 14.677% when pulling 15768f2 on auth-server into 10cd153 on master.

@coveralls

This comment has been minimized.

Copy link

coveralls commented Aug 9, 2017

Coverage Status

Coverage decreased (-3.4%) to 41.42% when pulling 2465f06 on auth-server into 10cd153 on master.

@coveralls

This comment has been minimized.

Copy link

coveralls commented Aug 9, 2017

Coverage Status

Coverage decreased (-1.5%) to 43.349% when pulling 03e3085 on auth-server into 10cd153 on master.

@coveralls

This comment has been minimized.

Copy link

coveralls commented Aug 9, 2017

Coverage Status

Coverage decreased (-1.5%) to 43.349% when pulling b1340fc on auth-server into 10cd153 on master.

Thatkookooguy added some commits Aug 9, 2017

NEVER save private config file
private config file should make it easier to save configuration to disk (DB url, etc)
create new configuration service
this will handle all configurations (also will save the configuration you add as argv if you add --savePrivate)

I still need to make this simpler, but it's already simpler than the previous one :-)
@coveralls

This comment has been minimized.

Copy link

coveralls commented Aug 9, 2017

Coverage Status

Coverage decreased (-22.3%) to 22.525% when pulling 02184df on auth-server into 10cd153 on master.

@coveralls

This comment has been minimized.

Copy link

coveralls commented Aug 10, 2017

Coverage Status

Coverage decreased (-22.4%) to 22.429% when pulling 0cce711 on auth-server into 10cd153 on master.

Thatkookooguy added some commits Aug 10, 2017

get the firebase admin from userService
later, should replace this with a function that does this internally
@coveralls

This comment has been minimized.

Copy link

coveralls commented Aug 10, 2017

Coverage Status

Coverage decreased (-22.5%) to 22.346% when pulling cf1cbe5 on auth-server into 10cd153 on master.

Thatkookooguy added some commits Aug 11, 2017

basic structure for userService specs
I want to change the functions inside userService to not use req and res so that it will be simpler to test.

after that change, I'll change this to test the actual file and not the function I mocked a few lines before :-)
@coveralls

This comment has been minimized.

Copy link

coveralls commented Aug 11, 2017

Coverage Status

Coverage decreased (-22.5%) to 22.346% when pulling cb1e915 on auth-server into 10cd153 on master.

@coveralls

This comment has been minimized.

Copy link

coveralls commented Aug 13, 2017

Coverage Status

Coverage decreased (-0.8%) to 44.055% when pulling 80168a2 on auth-server into 10cd153 on master.

@Thatkookooguy

This comment has been minimized.

Copy link
Member

Thatkookooguy commented Aug 13, 2017

Added all firebase variables to our heroku ENV variables (should work once we upload this PR)

@coveralls

This comment has been minimized.

Copy link

coveralls commented Aug 19, 2017

Coverage Status

Coverage increased (+1.7%) to 46.552% when pulling a71bfb0 on auth-server into 10cd153 on master.

@coveralls

This comment has been minimized.

Copy link

coveralls commented Aug 19, 2017

Coverage Status

Coverage decreased (-5.8%) to 39.017% when pulling fe43507 on auth-server into 10cd153 on master.

@Thatkookooguy Thatkookooguy requested a review from dunaevsky Aug 19, 2017

@coveralls

This comment has been minimized.

Copy link

coveralls commented Sep 29, 2017

Coverage Status

Coverage decreased (-5.8%) to 39.017% when pulling 16c17fc on auth-server into 8f12be2 on master.

@Thatkookooguy

This comment has been minimized.

Copy link
Member

Thatkookooguy commented Sep 29, 2017

talked with @dunaevsky about merging this in. Going to fix some of the implementation in the client side PR (notice that this shouldn't introduce any bugs since it's not hooked up to anything atm)

@Thatkookooguy Thatkookooguy merged commit c87b12c into master Sep 29, 2017

2 of 3 checks passed

coverage/coveralls Coverage decreased (-5.8%) to 39.017%
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@Thatkookooguy Thatkookooguy deleted the auth-server branch Nov 6, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment