New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update contributing #1460

Merged
merged 4 commits into from Aug 28, 2018

Conversation

Projects
None yet
3 participants
@n8225
Collaborator

n8225 commented Jul 5, 2018

  • Add https://n8225.github.io/ to contributing
  • Add guidelines for proprietary dependencies and propietary software to PR template

n8225 and others added some commits Jul 5, 2018

Update contributing and pr template
- Add https://n8225.github.io/ to contributing
- Add guidelines for proprietary dependencies and propietary software to PR template
syntax/spacing fixes, reword "proprietary dependencies", add plain en…
…glish description of ⚠ symbol requirement
Merge pull request #1461 from Kickball/nodiscc-patch-1
syntax/spacing fixes, reword "proprietary dependencies", add plain english description of ⚠ symbol requirement
@nodiscc

@n8225 thank you!

I spent some time testing the website, it works great. Only the File validater tab would sometimes telle the syntax is ok when in fact is was not. For example with this incorrect markdown syntax:

 - [simple-dash](https://github.com/Swagielka/simple-dash) - A simple, fully responsive Dashboard to forward to the services of your choice. ([Demo](http://simple-dash-demo.bplaced.net/), [Source(https://test)) `MIT` `PHP` 

But this is aminor bug, and I think it's a good tool to help contributors.

This PR also clears up confusion about placement of th symbol.

Good to merge!

@nodiscc nodiscc added fix tools labels Jul 15, 2018

@nodiscc nodiscc merged commit d3dea2c into master Aug 28, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@Kickball Kickball deleted the updateContributing branch Sep 20, 2018

@Kickball

This comment has been minimized.

Show comment
Hide comment
@Kickball

Kickball Sep 20, 2018

Owner

Looks great! Thanks @n8225 for putting this together 😄

Owner

Kickball commented Sep 20, 2018

Looks great! Thanks @n8225 for putting this together 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment