Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Fixed a bug where pool.connect() would fail. #1

Merged
merged 1 commit into from

2 participants

@nompute

Looks like it should've been "for(var key in this.Client.prototype)". I'm by no means familiar with javascript, but this seemed to fix the issue with using node-mysql-pool for me.

@Kijewski Kijewski merged commit 878aaec into Kijewski:master
@Kijewski
Owner

Thank you! The var was indeed missing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Mar 21, 2011
  1. Fixing a bug where pool.connect() would fail.

    Michael Lai authored
This page is out of date. Refresh to see the latest.
Showing with 1 addition and 1 deletion.
  1. +1 −1  lib/mysql-pool/pool.js
View
2  lib/mysql-pool/pool.js
@@ -188,7 +188,7 @@ MySQLPool.prototype._populate = function _populate() {
};
}
- for(key in this.Client.prototype) {
+ for(var key in this.Client.prototype) {
if(!key.match(/^[_A-Z]/) && !(key in this) && !(key in EventEmitter.prototype)) {
this[key] = mkPrototypeMethod(this.Client.prototype[key], key);
}
Something went wrong with that request. Please try again.