fix(code-reviews): drain stuck pending queues#3357
Merged
Conversation
Contributor
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Executive SummaryAll previously flagged issues have been addressed; the only new change since the last review is a Previous Issues (all resolved)
Files Reviewed (19 files)
Reviewed by claude-4.6-sonnet-20260217 · 904,209 tokens Review guidance: REVIEW.md from base branch |
alex-alecu
commented
May 20, 2026
alex-alecu
commented
May 20, 2026
alex-alecu
commented
May 20, 2026
alex-alecu
commented
May 20, 2026
alex-alecu
commented
May 20, 2026
Contributor
Author
|
Manual test passed. Tested:
Verified:
|
eshurakov
approved these changes
May 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Pending code reviews could wait a long time after a slot opened. They only woke up when another event arrived, so some reviews stayed parked even though work could continue.
What changed
This adds a scheduled queue sweep that wakes owners with reviews ready to try again. It reserves capacity safely before the slow work starts, so overlapping events do not take more slots than allowed. Old queued claims can recover again, and old running reviews are only shown as a warning signal, not failed automatically. The admin code review page now shows a live queue health card so support can see waiting work right away.
How to test
/admin/code-reviewsas an admin and confirmCurrent queue healthappears above the older telemetry cards.