New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

where is param bpf_filter? #69

Open
phith0n opened this Issue Mar 22, 2015 · 4 comments

Comments

Projects
None yet
3 participants
@phith0n

phith0n commented Mar 22, 2015

I can't find param bpf_filter in init function of FileCapture?
So I got a "TypeError: init() got an unexpected keyword argument 'bpf_filter' " error.

@KimiNewt

This comment has been minimized.

Show comment
Hide comment
@KimiNewt

KimiNewt Mar 24, 2015

Owner

It only exists on LiveCaptures at the moment.
IIRC, there was some problem when running it on FileCaptures, though I don't remember what it was-- so I'll try and check that out.

In the meanwhile, you can use the "display_filter" option, which is the standard wireshark filters (i.e. "http"). They're much more powerful, albeit slower.

Owner

KimiNewt commented Mar 24, 2015

It only exists on LiveCaptures at the moment.
IIRC, there was some problem when running it on FileCaptures, though I don't remember what it was-- so I'll try and check that out.

In the meanwhile, you can use the "display_filter" option, which is the standard wireshark filters (i.e. "http"). They're much more powerful, albeit slower.

@r2evans

This comment has been minimized.

Show comment
Hide comment
@r2evans

r2evans Mar 16, 2016

I appreciate the work you have done to deploy and maintain pyshark. However, perhaps you should remove the use of bpf_filter from your examples of FileCapture?

I don't think this is a pedantic request: there are two ways I learn about packages/modules: I read the docs and I read the source. I understand completely that it may be difficult to implement, and though I would prefer to have it than not, the docs and source are misleading.

r2evans commented Mar 16, 2016

I appreciate the work you have done to deploy and maintain pyshark. However, perhaps you should remove the use of bpf_filter from your examples of FileCapture?

I don't think this is a pedantic request: there are two ways I learn about packages/modules: I read the docs and I read the source. I understand completely that it may be difficult to implement, and though I would prefer to have it than not, the docs and source are misleading.

@KimiNewt

This comment has been minimized.

Show comment
Hide comment
@KimiNewt
Owner

KimiNewt commented Mar 16, 2016

@r2evans Done.

@r2evans

This comment has been minimized.

Show comment
Hide comment
@r2evans

r2evans Mar 16, 2016

Thanks! Good luck implementing it, I know it can be problematic. (I apologize for not being able to contribute much to it; though my python isn't terrible, my time and proficiency are not where they need to be to be of much help to you.)

r2evans commented Mar 16, 2016

Thanks! Good luck implementing it, I know it can be problematic. (I apologize for not being able to contribute much to it; though my python isn't terrible, my time and proficiency are not where they need to be to be of much help to you.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment