Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IDB.js library code doesn't handle transaction abort events #1043

Closed
asutherland opened this issue Aug 14, 2019 · 0 comments · Fixed by #1044

Comments

@asutherland
Copy link

commented Aug 14, 2019

Similar to how IndexedDB.jsm in the firefox tree needed to be updated to properly translate "abort" events to reject promises in https://bugzilla.mozilla.org/show_bug.cgi?id=1542181 in https://phabricator.services.mozilla.com/D36822, the code around

transaction.oncomplete = event => resolve(result);
needs to handle the abort event.

The general context in which this is a problem is when Firefox/Gecko is shutting down and QuotaManager shuts down but code like kinto and RemoteSettings are still active. QuotaManager will abort the outstanding transaction without necessarily firing an error event.

leplatrem added a commit that referenced this issue Aug 14, 2019
Fix #1043
leplatrem added a commit that referenced this issue Aug 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.