New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugins views hide default bucket #277

Closed
leplatrem opened this Issue Nov 17, 2015 · 1 comment

Comments

Projects
None yet
2 participants
@leplatrem
Contributor

leplatrem commented Nov 17, 2015

Currently, the default bucket views are registered after cliquet.initialize().

The plugin views (kinto.includes) are registered during cliquet.initialize().

The plugin views are hence registered before /buckets/default/*, and thus hide it.

This is a limitation for kinto-attachment which registers /buckets/{bucket_id}/collections/{collection_id}/records/{id}/attachment.

Possible solutions:

  • register default bucket views before cliquet.initialize(). Note: version prefix will thus have to be managed explicitly
  • add an kinto ready event on which plugins can hook to do last minute config modifications

Thoughts?

@Natim

This comment has been minimized.

Member

Natim commented Nov 17, 2015

I am wondering if we shouldn't put the default_bucket feature in a plugin and let the plugin order handle that current limitation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment