Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: MLIBZ-2230 Exception when class `node` has fields `node node` and `list node nodes` simultaneously #124

Conversation

@yuliya-guseva
Copy link
Contributor

commented Dec 6, 2017

Description

SDK throws an exception after dataStore.delete/sync/push calling if class Node has fields Node node and List<Node> nodes simultaneously. It happens because SDK doesn't create a field in realm table for inner Nood item for item in List.

Changes

Fixed creating a field in realm table for inner Nood item for item in List<Nood>.

Tests

Instrumented

feat: Improve self-reference case
Fix case when class `Node` has fields `Node node` and `List<Node> nodes` simultaneously

MLIBZ-2230

@yuliya-guseva yuliya-guseva requested a review from vinaygahlawat Dec 6, 2017

@codecov-io

This comment has been minimized.

Copy link

commented Dec 6, 2017

Codecov Report

❗️ No coverage uploaded for pull request base (indev@841655b). Click here to learn what that means.
The diff coverage is 86.95%.

Impacted file tree graph

@@           Coverage Diff            @@
##             indev     #124   +/-   ##
========================================
  Coverage         ?   57.28%           
  Complexity       ?      461           
========================================
  Files            ?       42           
  Lines            ?     3039           
  Branches         ?      474           
========================================
  Hits             ?     1741           
  Misses           ?     1153           
  Partials         ?      145
Impacted Files Coverage Δ Complexity Δ
.../main/java/com/kinvey/android/cache/ClassHash.java 64% <86.95%> (ø) 117 <1> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 841655b...c268909. Read the comment docs.

Merge branch 'indev' into feature/MLIBZ-2230_Exception_when_class_`No…
…de`_has_fields_`Node_node`_and_`List_Node__nodes`_simultaneously

# Conflicts:
#	android-lib/src/androidTest/java/com/kinvey/androidTest/store/DataStoreTest.java
#	android-lib/src/main/java/com/kinvey/android/cache/ClassHash.java
Merge branch 'indev' into feature/MLIBZ-2230_Exception_when_class_`No…
…de`_has_fields_`Node_node`_and_`List_Node__nodes`_simultaneously

@yuliya-guseva yuliya-guseva merged commit 1caee86 into indev Mar 27, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@yuliya-guseva yuliya-guseva deleted the feature/MLIBZ-2230_Exception_when_class_`Node`_has_fields_`Node_node`_and_`List_Node__nodes`_simultaneously branch Mar 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.