Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/mlibz 2171 logout does not invalidate access token #140

Conversation

@vinaygahlawat
Copy link
Contributor

commented Feb 9, 2018

Description

Logout call was only acting locally, not making _logout request to backend.

Changes

Making the logout request now as part of hard logout.

Tests

Instrumented, manual

@vinaygahlawat vinaygahlawat requested a review from yuliya-guseva Feb 9, 2018

@codecov-io

This comment has been minimized.

Copy link

commented Feb 16, 2018

Codecov Report

Merging #140 into indev will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##              indev     #140      +/-   ##
============================================
- Coverage     56.71%   56.68%   -0.04%     
+ Complexity      438      437       -1     
============================================
  Files            41       41              
  Lines          2932     2932              
  Branches        457      457              
============================================
- Hits           1663     1662       -1     
  Misses         1128     1128              
- Partials        141      142       +1
Impacted Files Coverage Δ Complexity Δ
...in/java/com/kinvey/android/AsyncClientRequest.java 63.63% <0%> (-3.04%) 10% <0%> (-1%)
...d-lib/src/main/java/com/kinvey/android/Client.java 52.41% <0%> (ø) 16% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9267f8d...6418864. Read the comment docs.

@yuliya-guseva
Copy link
Contributor

left a comment

The changes LGTM. Locally the tests are passed at my Laptop. But I think it will be good to have stable tests at the Travis as well.

@vinaygahlawat vinaygahlawat merged commit 69e80cf into indev Mar 2, 2018

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
@vinaygahlawat

This comment has been minimized.

Copy link
Contributor Author

commented Mar 2, 2018

Merging now, although there may be some issues with Travis integration tests. All tests are passing locally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.