Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: MLIBZ-2433 Enable instance.id in properties file #163

Merged

Conversation

@yuliya-guseva
Copy link
Contributor

commented Apr 12, 2018

Description

Enable instance.id in properties file

Changes

Added instance.id as a possible parameter to the properties file.
If setBaseUrl and setInstanceId are used in the Client.Builder, the order of these methods call is important, last option will be used. For examle (Client.Builder(mContext).setBaseUrl("BaseUrl").setInstanceID("TestInstanceId").build()), in this case instanceID will be used, if setBaseUrl will be after setInstanceID then baseUrl parameter will be used.
For properties file, the options order doesn't matter, in all cases, instanceID will be used if it exists.

Tests

Instrumented, Manual

@yuliya-guseva yuliya-guseva requested a review from vinaygahlawat Apr 12, 2018

@vinaygahlawat
Copy link
Contributor

left a comment

LGTM

feat: Update test
MLIBZ-2433
@codecov-io

This comment has been minimized.

Copy link

commented Apr 12, 2018

Codecov Report

Merging #163 into indev will decrease coverage by 0.03%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff              @@
##              indev     #163      +/-   ##
============================================
- Coverage     57.42%   57.38%   -0.04%     
  Complexity      462      462              
============================================
  Files            42       42              
  Lines          3044     3046       +2     
  Branches        475      476       +1     
============================================
  Hits           1748     1748              
- Misses         1152     1153       +1     
- Partials        144      145       +1
Impacted Files Coverage Δ Complexity Δ
...d-lib/src/main/java/com/kinvey/android/Client.java 52.86% <0%> (-0.36%) 16 <0> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 227c198...1771dfe. Read the comment docs.

@yuliya-guseva yuliya-guseva merged commit bf43f95 into indev Apr 13, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@yuliya-guseva yuliya-guseva deleted the feature/MLIBZ-2433_Enable_Instance_ID_in_properties_files branch Apr 13, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.