Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: MLIBZ-2494 Enable support for TLSv1.1 and TLSv1.2 for 4.1-4.4 Android versions #178

Conversation

@yuliya-guseva
Copy link
Contributor

commented Jun 19, 2018

Description

Enable support for TLSv1.1 and TLSv1.2 for 4.1-4.4 Android versions.

Changes

Enabled support for TLSv1.1 and TLSv1.2 for 4.1-4.4 Android versions.
Increased min SDK version to API 16

Tests

Tested manually at the environment with disabled TLSv1.
Instrumented tests are passed with new SocketFactory at the current backend.

@yuliya-guseva yuliya-guseva requested a review from vinaygahlawat Jun 19, 2018

@yuliya-guseva yuliya-guseva changed the title feat: MLIBZ-2494 Enable support for TLSv1.1 and TLSv1.2 feat: MLIBZ-2494 Enable support for TLSv1.1 and TLSv1.2 for 4.1-4.4 Android versions Jun 19, 2018

@codecov-io

This comment has been minimized.

Copy link

commented Jun 20, 2018

Codecov Report

Merging #178 into indev will decrease coverage by 0.47%.
The diff coverage is 3.57%.

Impacted file tree graph

@@             Coverage Diff              @@
##              indev     #178      +/-   ##
============================================
- Coverage     58.13%   57.65%   -0.48%     
  Complexity      473      473              
============================================
  Files            41       42       +1     
  Lines          3134     3160      +26     
  Branches        479      479              
============================================
  Hits           1822     1822              
- Misses         1163     1189      +26     
  Partials        149      149
Impacted Files Coverage Δ Complexity Δ
...n/java/com/kinvey/android/KinveySocketFactory.java 0% <0%> (ø) 0 <0> (?)
...d-lib/src/main/java/com/kinvey/android/Client.java 51.14% <8.33%> (-1.73%) 16 <0> (ø)
...in/java/com/kinvey/android/AsyncClientRequest.java 63.63% <0%> (-3.04%) 10% <0%> (-1%)
...n/java/com/kinvey/android/KinveyHandlerThread.java 86.36% <0%> (+4.54%) 8% <0%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e883743...01a1f60. Read the comment docs.

@vinaygahlawat
Copy link
Contributor

left a comment

Overall LGTM, but a couple of questions, and also need to verify that this new minSdkVersion is the correct version.

@@ -724,7 +724,7 @@ public LoginToTempURL MICLoginToTempURL(String username, String password, String
data.put("password", password);

HttpContent content = new UrlEncodedContent(data);
LoginToTempURL loginTemp = new LoginToTempURL(this, tempURL, clientId, content);
LoginToTempURL loginTemp = new LoginToTempURL(this, clientId, tempURL, content);
loginTemp.setRequireAppCredentials(true);

This comment has been minimized.

Copy link
@vinaygahlawat

vinaygahlawat Jun 22, 2018

Contributor

Does this change have to do with the TLS fix?

This comment has been minimized.

Copy link
@yuliya-guseva

yuliya-guseva Jun 22, 2018

Author Contributor

No, It's improvement for MIC. Do you think it should be filed as separate ticket(PR)?

This comment has been minimized.

Copy link
@vinaygahlawat

vinaygahlawat Jun 22, 2018

Contributor

Yes I think that is best. I created MLIBZ-2576 for this, please move this change to a branch for that ticket.

@@ -25,7 +25,7 @@
* Created by Prots on 2/12/16.
*/
public final class GetMICTempURL extends AbstractKinveyClientRequest<GenericJson> {
private static final String REST_PATH = "oauth/auth";
private static final String REST_PATH = "oauth/auth?scope=openid";

This comment has been minimized.

Copy link
@vinaygahlawat

vinaygahlawat Jun 22, 2018

Contributor

Does this change have to do with the TLS fix?

This comment has been minimized.

Copy link
@yuliya-guseva

yuliya-guseva Jun 22, 2018

Author Contributor

No, It's improvement for MIC. Do you think it should be filed as separate ticket(PR)?

This comment has been minimized.

Copy link
@vinaygahlawat

vinaygahlawat Jun 22, 2018

Contributor

Yes I think that is best. I created MLIBZ-2576 for this, please move this change to a branch for that ticket.

@yuliya-guseva yuliya-guseva merged commit 8407329 into indev Jun 28, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@yuliya-guseva yuliya-guseva deleted the feature/MLIBZ-2494_Disable_support_for_SSL-TLSv1_in_3.x_library_version branch Jun 28, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.