Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: MLIBZ-2576 MIC fixes for `scope=openid` and `clientID` #181

Conversation

@yuliya-guseva
Copy link
Contributor

commented Jun 25, 2018

Description

MIC fixes for scope=openid and clientID

Changes

Added ?scope=openid in the end of url in GetMICTempURL request.
Updated clientID position for LoginToTempURL creation in the MICLoginToTempURL method.

Tests

Unit tests

feat: Fix parameters order for MIC login with temp url and add scope=…
…openid parameter for getting temp url for MIC login

MLIBZ-2576

@yuliya-guseva yuliya-guseva requested a review from vinaygahlawat Jun 25, 2018

@codecov-io

This comment has been minimized.

Copy link

commented Jun 25, 2018

Codecov Report

Merging #181 into indev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##              indev     #181   +/-   ##
=========================================
  Coverage     58.13%   58.13%           
  Complexity      473      473           
=========================================
  Files            41       41           
  Lines          3134     3134           
  Branches        479      479           
=========================================
  Hits           1822     1822           
  Misses         1163     1163           
  Partials        149      149

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e883743...21ad2b8. Read the comment docs.

@vinaygahlawat
Copy link
Contributor

left a comment

LGTM

@yuliya-guseva yuliya-guseva merged commit df41970 into indev Jun 28, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@yuliya-guseva yuliya-guseva deleted the feature/MLIBZ-2576_MIC_fixes_for_`scope=openid`_and_`clientID` branch Jun 28, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.