Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MLIBZ - 2882 Make network requests async #219

Merged
merged 5 commits into from Mar 1, 2019

Conversation

@b-stolyarov
Copy link
Collaborator

commented Feb 25, 2019

Description

Make network requests async

Changes

Changed requests for async

Tests

Instrumented

@b-stolyarov b-stolyarov requested a review from vinaygahlawat Feb 25, 2019

@codecov-io

This comment has been minimized.

Copy link

commented Mar 1, 2019

Codecov Report

Merging #219 into indev will increase coverage by 0.07%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##              indev     #219      +/-   ##
============================================
+ Coverage     69.66%   69.73%   +0.07%     
+ Complexity      581      580       -1     
============================================
  Files            41       41              
  Lines          3161     3172      +11     
  Branches        478      478              
============================================
+ Hits           2202     2212      +10     
  Misses          796      796              
- Partials        163      164       +1
Impacted Files Coverage Δ Complexity Δ
...in/java/com/kinvey/android/AsyncClientRequest.java 70% <100%> (+3.33%) 9 <4> (-1) ⬇️
.../main/java/com/kinvey/android/store/DataStore.java 85.04% <100%> (+0.26%) 40 <0> (ø) ⬇️
.../main/java/com/kinvey/android/store/UserStore.java 71.84% <0%> (ø) 35% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e9231f5...30438d3. Read the comment docs.

@b-stolyarov b-stolyarov merged commit dc3266d into indev Mar 1, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@b-stolyarov b-stolyarov deleted the feature/MLIBZ-2882_Make_network_requests_async branch Mar 1, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.