Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MLIBZ-2891 Use multi-threading model to handle network requests #220

Conversation

@b-stolyarov
Copy link
Collaborator

commented Mar 5, 2019

Description

Use multi-threading model to handle network requests

Changes

Added logic with pool of threads for requests

Tests

Instrumented

@b-stolyarov b-stolyarov requested a review from vinaygahlawat Mar 5, 2019

@vinaygahlawat
Copy link
Contributor

left a comment

Overall LGTM, but need to add tests for this. Also, what performance gains have you seen with this change?

@b-stolyarov

This comment has been minimized.

Copy link
Collaborator Author

commented Mar 7, 2019

Performance gains depends on the number of threads that we set in kinvey.properties file for pool of threads. For example after my test for saving 1500 entities I have about 5 minutes delay with 1 thread and I have delay about 25 seconds for pool with 15 threads

@b-stolyarov b-stolyarov merged commit f20fd5a into indev Mar 12, 2019

1 of 2 checks passed

continuous-integration/travis-ci/push The Travis CI build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@b-stolyarov b-stolyarov deleted the feature/MLIBZ-2891_Use_multi-threading_model_to_handle_network_requests branch Mar 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.