Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kotlin migration #239

Merged
merged 8 commits into from Jul 16, 2019

Conversation

@b-stolyarov
Copy link
Collaborator

commented Jul 9, 2019

Description

Kotlin migration

Changes

Updated Gradle version to 5.1.1,
Support for Kotlin added
Changed JavaDoc generating tool from Doclava to Dokka

Tests

Instrumented

b-stolyarov and others added 5 commits Jun 22, 2019
MLIBZ-2770: Upgrade to Gradle v5 (#237)
* update gradle version and library dependencies, removed unused libs

* update gradle version and library dependencies, updated gradle config files

* update gradle version and library dependencies, added kotlin support

* update gradle version and library dependencies, gradle config files update

* update gradle version and library dependencies, tests fixes after gradle update

@b-stolyarov b-stolyarov requested review from heyzooi and vinaygahlawat Jul 9, 2019

@b-stolyarov b-stolyarov changed the base branch from indev to master Jul 9, 2019

android-lib/build.gradle Outdated Show resolved Hide resolved
android-lib/build.gradle Outdated Show resolved Hide resolved
@heyzooi
Copy link
Contributor

left a comment

looks good overall, just have a few questions

@heyzooi
heyzooi approved these changes Jul 9, 2019

@b-stolyarov b-stolyarov requested a review from heyzooi Jul 15, 2019

@heyzooi
Copy link
Contributor

left a comment

LGTM

@b-stolyarov b-stolyarov merged commit 3b33d75 into master Jul 16, 2019

1 check failed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details

@b-stolyarov b-stolyarov deleted the kotlin-migration branch Jul 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.