Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MLIBZ-2549: Using Auto-pagination does not work #193

Merged
merged 4 commits into from Jan 30, 2019

Conversation

romanogolikhin
Copy link
Contributor

@romanogolikhin romanogolikhin commented Jan 22, 2019

Description

Steps to reproduce:

  1. Enable AP for a store
  2. Pull

Expected result: The AP is utilised - a _count request is sent, then the items are retrieved in batches according to the specified size
Actual result: The AP is utilised, but after the _count request, which succeeds, the following error occurs: Value cannot be null, Parameter name: source

Changes

Changing PagedPullRequest.cs.

Tests

TestSyncStorePullWithAutoPaginationQueryNullAsync()
TestSyncStorePullWithAutoPaginationQueryNotNullAsync()
TestSyncStorePullWithAutoPaginationReceivingMoreThan10kRecordsAsync()

Copy link
Contributor

@heyzooi heyzooi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@romanogolikhin do you know if there's a unit test that tests more than 10k records? Since its the limit for the backend

@romanogolikhin
Copy link
Contributor Author

@heyzooi No, we didn't have a unit test to test more than 10k records. But I have created it. You can have a look.

@romanogolikhin romanogolikhin merged commit 5970727 into develop Jan 30, 2019
@romanogolikhin romanogolikhin deleted the feature/MLIBZ-2549-Auto_Pagination_Not_Work branch January 30, 2019 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants