Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MLIBZ-1626: Add unit tests for user logout #110

Merged
merged 3 commits into from Feb 23, 2017

Conversation

@thomasconner
Copy link
Contributor

commented Feb 20, 2017

Description

This PR adds unit tests for user logout.

Changes

  • Add unit tests for user logout.

@thomasconner thomasconner self-assigned this Feb 20, 2017

@codecov-io

This comment has been minimized.

Copy link

commented Feb 20, 2017

Codecov Report

Merging #110 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##           master   #110   +/-   ##
=====================================
  Coverage      78%    78%           
=====================================
  Files          86     86           
  Lines        6998   6998           
  Branches     1134   1134           
=====================================
  Hits         5459   5459           
  Misses       1539   1539

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 77fab77...c4dc8fe. Read the comment docs.

@@ -211,6 +211,30 @@ describe('User', function() {
});
});

describe('logout()', function() {

This comment has been minimized.

Copy link
@tejasranade

tejasranade Feb 20, 2017

Member

@thomasconner the logout() tests should assert more that just the active user API. Please add some asserts for the cache being cleaned, sync queue emptied and checks for any other local storage items we remove (e.g. device tokens, SQL tables etc)

This comment has been minimized.

Copy link
@thomasconner

thomasconner Feb 23, 2017

Author Contributor

@tejasranade I have added some checks for these items.

@tejasranade
Copy link
Member

left a comment

Lgtm

@thomasconner thomasconner merged commit c4dc8fe into master Feb 23, 2017

4 checks passed

codeclimate no new or fixed issues
Details
codecov/patch Coverage not affected when comparing 77fab77...c4dc8fe
Details
codecov/project 78% remains the same compared to 77fab77
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@thomasconner thomasconner deleted the MLIBZ-1626_Logout_Issue branch Feb 23, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.