Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add method to remove user by id. #114

Merged
merged 6 commits into from Mar 15, 2017

Conversation

@tejasranade
Copy link
Member

commented Mar 14, 2017

Description

Adds a new method to the User class to remove user by ID.

Changes

  • New removeById() method implemented in UserStore. The implementation includes option hard=true, which permanently deletes the user.
  • New remove(id) static method in User, which directs to the UserStore.
  • Tests to cover new APIs.

Tests

  • New tests added for new APIs.
  • Tested with an Angular sample app.

@tejasranade tejasranade requested a review from thomasconner Mar 14, 2017

@codecov-io

This comment has been minimized.

Copy link

commented Mar 14, 2017

Codecov Report

Merging #114 into master will increase coverage by 0.09%.
The diff coverage is 88.88%.

@@            Coverage Diff             @@
##           master     #114      +/-   ##
==========================================
+ Coverage   77.81%   77.91%   +0.09%     
==========================================
  Files          86       86              
  Lines        6893     6928      +35     
  Branches     1129     1133       +4     
==========================================
+ Hits         5364     5398      +34     
- Misses       1529     1530       +1
Impacted Files Coverage Δ
src/entity/src/user.js 55.39% <100%> (+0.33%)
src/datastore/src/userstore.js 78.46% <85.71%> (+5.73%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e066305...1763a89. Read the comment docs.

@thomasconner
Copy link
Contributor

left a comment

LGTM

@thomasconner thomasconner merged commit 578f3c3 into master Mar 15, 2017

1 of 2 checks passed

continuous-integration/travis-ci/push The Travis CI build is in progress
Details
codeclimate no new or fixed issues
Details

@thomasconner thomasconner deleted the MLIBZ-1733_user_remove branch Mar 15, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.