Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MLIBZ-1732: Prevent sync push from being sent when one is already in progress. #117

Merged
merged 2 commits into from Mar 21, 2017

Conversation

@thomasconner
Copy link
Contributor

commented Mar 20, 2017

Description

A user could kick off multiple sync push operations at once causing unexpected behaviors. This PR fixes this bug from preventing multiple sync push operations from being executed at the same time. If a sync push operation is already in progress, other sync push operations will fail immediately and must wait until the current sync push operation completes.

Changes

  • Add flag to mark if a sync push operation is in progress.
  • Add a unit test to ensure only one sync push operation is possible.

@thomasconner thomasconner self-assigned this Mar 20, 2017

@thomasconner thomasconner requested a review from tejasranade Mar 20, 2017

@tejasranade
Copy link
Member

left a comment

LGTM.

@thomasconner thomasconner merged commit a325f3c into master Mar 21, 2017

3 of 4 checks passed

codecov/project No report found to compare against
Details
codeclimate no new or fixed issues
Details
codecov/patch Coverage not affected.
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@thomasconner thomasconner deleted the MLIBZ-1271_sync branch Mar 21, 2017

@thomasconner thomasconner changed the title MLIBZ-1271: Prevent sync push from being sent when one is already in progress. MLIBZ-1732: Prevent sync push from being sent when one is already in progress. Apr 7, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.