New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use tls: true as default when finding files #118

Merged
merged 1 commit into from Mar 27, 2017

Conversation

Projects
None yet
2 participants
@thomasconner
Contributor

thomasconner commented Mar 27, 2017

Description

We should always default to using https urls by default when looking up files.

Changes

  • use tls: true as default for finding files

@thomasconner thomasconner self-assigned this Mar 27, 2017

@thomasconner thomasconner requested a review from tejasranade Mar 27, 2017

@tejasranade

@thomasconner The change makes sense, but what prompted it? Also, what did you test it with?

@thomasconner thomasconner merged commit 2d04c2b into master Mar 27, 2017

4 checks passed

codeclimate no new or fixed issues
Details
codecov/patch 100% of diff hit (target 78.16%)
Details
codecov/project 78.16% (+0%) compared to ab06f97
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@thomasconner thomasconner deleted the default_tls_flag_true branch Mar 27, 2017

@thomasconner

This comment has been minimized.

Contributor

thomasconner commented Mar 27, 2017

I was testing with the HTML5 starter app and noticed that when I loaded the files the _downloadUrl was using http and not https by default. In the file guide on the Dev Center we make the statement The library always communicates with Google Cloud Storage using the https protocol. If you want to use http instead, the options argument in the methods described below allow for a tls: false flag. This changes makes this statement true. We should have been using tls: true by default all along.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment