Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MLIBZ-1999: Mono Repo #171

Merged
merged 350 commits into from Dec 14, 2017

Conversation

@thomasconner
Copy link
Contributor

commented Nov 28, 2017

This moves all the code from the individual repositories that make of the JavaScript SDKs into this repository as a mono repo format.

tsvetomir-nedyalkov and others added 6 commits Dec 4, 2017
Merge branch 'MLIBZ-1999_Mono_Repo' into user-mismatch-MLIBZ-2150
* MLIBZ-1999_Mono_Repo:
  Moved source code to src folder so that babel will transpile the source code when the packages are bundled
  Export MobileIdentityConnect module
  Export a few modulse for kinvey-js-sdk
Merge branch 'MLIBZ-1999_Mono_Repo' into ts-definitions
* MLIBZ-1999_Mono_Repo:
  Moved source code to src folder so that babel will transpile the source code when the packages are bundled
  Export MobileIdentityConnect module
  Export a few modulse for kinvey-js-sdk

# Conflicts:
#	src/nativescript/kinvey.d.ts
@georgiwe

This comment has been minimized.

Copy link
Contributor

commented Dec 5, 2017

I have a concern about the release procedure. To me, it seemed rather complicated in general. But the two parts I can point out as leaving the biggest impression are

  • Travis taking actions on push of tags, regardless of the tags (this is my understanding of how it works) - maybe that's not a problem, but also adding a couple of validations shouldn't be too difficult either
  • the bash file in each repo, which seems pretty important - I'm curious does that have to be committed in source control? isn't there a way to run a few lines of bash from Travis or someplace else?

These are the two things that stick out in my mind, but there was a lot more involved (understandably so) in the procedures that Travis runs. I think it's worth it going over those again.

@thomasconner

This comment has been minimized.

Copy link
Contributor Author

commented Dec 5, 2017

  1. This one doesn't make sense to me. Why would a tag be created if it isn't suppose to be release?

  2. Please take a look at https://docs.travis-ci.com/user/customizing-the-build/#Implementing-Complex-Build-Steps. This is the way travis recommends using a custom shell script for complex build steps. We need to push the dist created by travis back to the respective git repos in order for customers who use bower to be able to install the latest release. This custom shell script uses an access token that is encrypted for pushing the code back to the git repo. Am I missing something that causes this to be insecure?

tsvetomir-nedyalkov and others added 4 commits Dec 7, 2017
Merge pull request #183 from Kinvey/ts-definitions
MLIBZ-2129 TypeScript definitions update
Merge pull request #173 from Kinvey/user-mismatch-MLIBZ-2150
MLIBZ-2150 Fix return value of ActiveUserStorage.set() for NativeScript.
thomasconner and others added 10 commits Dec 11, 2017
MLIBZ-2150 Remove redundant modifications of the value to be saved be…
…fore saving it. They are present in the set() methods of SecureStorage for both Android and iOS.
Merge pull request #194 from Kinvey/remove_plugins_from_nativescript_sdk
Remove nativescript-push-notifications as a dependency
Merge pull request #196 from Kinvey/user-mismatch-fix
MLIBZ-2150 Fix setting active user in NativeScript SDK
Merge pull request #184 from Kinvey/MLIBZ-2225_findById_bug
MLIBZ-2225: datastore.findById() should throw a NotFoundError if the id argument is not defined
Update PubNub to version that contains support for NativeScript (#193)
* Update pubnub

* Bundle nativescript pubnub with nativescript sdk
MLIBZ-2234: Export the Kinvey namespace as a module for new bundles c…
…reated from Mono repo (#185)

* Export all modules under the Kinvey namespace

* Update webpack configs to point to correct entry file

* Update kinvey.d.ts

* Remove liveServiceHostname from kinvey.d.ts

@thomasconner thomasconner merged commit a09bbea into master Dec 14, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@thomasconner thomasconner deleted the MLIBZ-1999_Mono_Repo branch Dec 14, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.