Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use NativeScript PubNub with kinvey-nativescript-sdk #193

Merged
merged 2 commits into from Dec 13, 2017

Conversation

@thomasconner
Copy link
Contributor

commented Dec 11, 2017

Description

Replace the import 'pubnub' with import 'pubnub/lib/nativescript' using webpack.

@thomasconner thomasconner requested review from tejasranade and georgiwe Dec 11, 2017

@thomasconner thomasconner self-assigned this Dec 11, 2017

@chrismllr

This comment has been minimized.

Copy link
Contributor

commented Dec 11, 2017

Hey @thomasconner -

Deleting your fork off the pubnub repo is breaking all npm installs of the latest version of the js-sdk (seeing it on 3.9.0)...

error An unexpected error occurred: "https://codeload.github.com/thomasconner/javascript/tar.gz/07398c28df8bd2308e0c853818013134811c6de3: Request failed \"404 Not Found\"".

Is the plan that this PR will be merged ASAP?

@thomasconner

This comment has been minimized.

Copy link
Contributor Author

commented Dec 12, 2017

@chrismllr I have recreated the fork which should resolve the issue.

@chrismllr

This comment has been minimized.

Copy link
Contributor

commented Dec 12, 2017

Thanks @thomasconner - can confirm all is back to normal.

@@ -235,7 +235,8 @@
"async": {
"version": "1.5.2",
"resolved": "https://registry.npmjs.org/async/-/async-1.5.2.tgz",
"integrity": "sha1-7GphrlZIDAw8skHJVhjiCJL5Zyo="
"integrity": "sha1-7GphrlZIDAw8skHJVhjiCJL5Zyo=",

This comment has been minimized.

Copy link
@tejasranade

tejasranade Dec 13, 2017

Member

Should the package-lock file even be under source control? If not, you should add it to .gitignore.

This comment has been minimized.

Copy link
@thomasconner

thomasconner Dec 13, 2017

Author Contributor

It seems like you should include the package-lock.json file in source control. https://stackoverflow.com/questions/44206782/do-i-commit-the-package-lock-json-file-created-by-npm-5

@thomasconner thomasconner merged commit ced200d into MLIBZ-1999_Mono_Repo Dec 13, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@thomasconner thomasconner deleted the update_pubnub branch Dec 13, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.