Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MLIBZ-2422: Validate MIC RedirectUri #283

Merged
merged 2 commits into from Apr 25, 2018

Conversation

@thomasconner
Copy link
Contributor

commented Apr 6, 2018

Description

Adds validation that checks if a redirectUri provided to mic.login() is provided and a string.

Changes

  • Return a rejected Promise if the redirectUri provided to mic.login() is invalid.

Tests

  • Added a test that checks that mic.login() fails when no redirectUri is provided.
  • Added a test that checks that mic.login() fails when redirectUri is not a string.

@thomasconner thomasconner self-assigned this Apr 6, 2018

@thomasconner thomasconner requested a review from tejasranade Apr 6, 2018

@tejasranade
Copy link
Member

left a comment

LGTM

@thomasconner thomasconner merged commit 0fb8c64 into master Apr 25, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@thomasconner thomasconner deleted the MLIBZ-2422_Validate_MIC_-RedirectUri branch Apr 25, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.