Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
MLIBZ-2323: Thrown error in onNext() in observable causes silent observable unsubscribe #302
When an error in the onNext() function is thrown, the error is silently handled by the SDK and an unsubscribe from the observable is called, thus leaving the developer without notification that something went wrong.
A running sample describing the above can be found here. Without a try-catch block, trying to access a property from the returned entities will cause an error as the first fetched result would be from the localStorage and thus an empty array. The thrown error will not be shown to the developer causing a silent unsubscribe from the observable.
Overall LGTM, but just have one question to be answered before approval.